Skip to content

CloudFormation troubleshooting lab: reset waits for the group's instances - #80

Merged
returnvalue merged 1 commit into
mainfrom
claude/cfn-troubleshooting-reset
Nov 7, 2026
Merged

returnvalue merged 1 commit into
mainfrom
claude/cfn-troubleshooting-reset

Conversation

@returnvalue

Copy link
Copy Markdown
Collaborator

Requested by Chris

What broke

After every run of cloudformation/deployment-troubleshooting on Floci 2.4.0, the lab-deploy-network stack stayed in DELETE_FAILED ("The vpc ... has dependencies") while reset reported "The share, AMIs, stacks, network interfaces, and deployer user are gone." check_labs still passed, and the leftover stack later tripped dashboard.integration_tests.

Cause: reset force-deletes the Auto Scaling group and then deletes the network stack straight away. Floci's instances are still shutting-down at that moment, so the subnets and VPC can't go. A few seconds later they're terminated (a second reset cleaned it up).

Fix

  • Reset waits (up to 2 minutes) for instances in the lab's subnets to finish terminating before deleting the network stack.
  • If the network stack is still there after the delete, reset reports it as an error instead of success.

Checks

  • Unit tests: 2 new reset tests; ruff check . clean.
  • check_labs --service cloudformation --lab deployment-troubleshooting twice on a throwaway Floci 2.4.0: passes, no stacks left, errors: [].

🤖 Generated with Claude Code

@returnvalue returnvalue self-assigned this Nov 7, 2026
…nces

Reset force-deleted the Auto Scaling group and deleted the network stack at
once; the instances were still shutting down, so the VPC and subnets failed
to delete and the stack stayed in DELETE_FAILED while reset reported success.
Wait for instances in the lab subnets to terminate first, and report an error
if the network stack is still there after the delete.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@returnvalue
returnvalue force-pushed the claude/cfn-troubleshooting-reset branch from d5359d1 to 7c4c561 Compare November 7, 2026 18:52
@returnvalue
returnvalue merged commit 6c4bd90 into main Nov 7, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant